Skip to content

enhancement(python): Moved pip backend and it's unit tests to a /python directory#1642

Open
mohamedbouchtout wants to merge 1 commit into
hermetoproject:mainfrom
mohamedbouchtout:feature/group-python-backends
Open

enhancement(python): Moved pip backend and it's unit tests to a /python directory#1642
mohamedbouchtout wants to merge 1 commit into
hermetoproject:mainfrom
mohamedbouchtout:feature/group-python-backends

Conversation

@mohamedbouchtout

Copy link
Copy Markdown
Collaborator

resolves #1548

Summery

Created a /python directory for the pip backend and pip unit tests as requested in this issue, similar to what was done with the javascript package managers. Updated import paths to match the relocation.

Details

  1. Moved the pip backend to a /python directory
  2. Moved the pip unit tests to a /python directory to match the backend structure
  3. Future python package managers will be placed in the /python directory (e.g, uv)

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the project structure by moving the pip package manager under a new python namespace directory (hermeto/core/package_managers/python/pip). All corresponding imports and unit tests have been updated to reflect this new path. I have no feedback to provide as the changes are clean and consistent.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@mohamedbouchtout mohamedbouchtout force-pushed the feature/group-python-backends branch from 04fef11 to 9ca18db Compare July 1, 2026 13:37

@eskultety eskultety left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One "mentoring" comment left as an improvement item ;). ACK to the change.

Comment thread hermeto/core/package_managers/python/pip/__init__.py
@mohamedbouchtout mohamedbouchtout force-pushed the feature/group-python-backends branch from 9ca18db to 1ab99f9 Compare July 1, 2026 17:46

@tnevrlka tnevrlka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM, few style notes that I would like to see addressed before merging:

  • Consider using the 50/72 rule -- try to fit the title under 50 chars and keep lines in a body under 72 chars, then wrap
  • it's -> its
  • Use imperative, e.g. Moved -> Move

@eskultety

Copy link
Copy Markdown
Member

Code changes LGTM, few style notes that I would like to see addressed before merging:

* Consider using the 50/72 rule -- try to fit the title under 50 chars and keep lines in a body under 72 chars, then wrap 

While I acknowledge ^this to be the official recommendation (even by the git book itself?) even I don't follow the 50c rule on the subject line for 2 reasons:

  1. 50c is quite limiting in delivering good descriptive subjects (let alone using conventional commits syntax..)
  2. I didn't find it worth my time figuring out whether I could have a floating wrap column in my vim based setup on the git file type and so I only set it to 72 globally for git related stuff. I would not be fond of enforcing 50c which would make my vim life harder, but should it become a rule, I will respect it.

That said, even 80c is nowadays deemed restrictive, but that's because many people fancy an ultrawide screen and working in an IDE. For those who still rock terminal setup in 24" fullHD screens 80-100c is still quite vital :), my 2 cents.

Create a /python directory for pip backend and unit tests. Closes hermetoproject#1548

Signed-off-by: Mohamed Bouchtout <mbouchto@redhat.com>
@mohamedbouchtout mohamedbouchtout force-pushed the feature/group-python-backends branch from 1ab99f9 to da77a07 Compare July 2, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Group Python backends in a shared directory

4 participants